Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added callback feature to decision tree with test #41

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster grantbuster requested a review from ppinchuk December 11, 2024 20:58
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look solid. My only comment is that it's not entirely obvious what the benefit of this feature is. I think you and I discussed being able to include loop-like structures in the tree itself. Would you be able to do that with this functionality? Is the intention of the callback to dynamically build and/or modify the tree such that it creates a loop?

@ppinchuk ppinchuk mentioned this pull request Jan 8, 2025
@grantbuster
Copy link
Member Author

Code changes look solid. My only comment is that it's not entirely obvious what the benefit of this feature is. I think you and I discussed being able to include loop-like structures in the tree itself. Would you be able to do that with this functionality? Is the intention of the callback to dynamically build and/or modify the tree such that it creates a loop?

You could call other trees from this but it wouldn't be able to pass information back to the origin i dont think. Uma wanted something like this to be able to build an output dataset in-situ while the tree ran. I think it's good to have callback triggers for the tree anyway. increase the options for dynamic interaction.

@grantbuster grantbuster merged commit 6119620 into main Jan 10, 2025
15 checks passed
@grantbuster grantbuster deleted the gb/dtree_callback branch January 10, 2025 17:23
github-actions bot pushed a commit that referenced this pull request Jan 10, 2025
added callback feature to decision tree with test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants